Import graph

This is the import graph of src/ at the end of Phase 7, the last phase of the refactor plan, on the branch refactor/07final. It records where the refactor left the graph: which folders reach vscode, which import each other the wrong way, which mocha suites can run without the extension host, and which module-level state is left. The rules that hold the graph to its target, and the violations recorded as known, are described in the layers page.

Everything below the line is printed by node scripts/import-graph-report.js, which reads the graph with dependency-cruiser and the rules’ own configuration, .dependency-cruiser.cjs. Type-only imports count, since a type imported the wrong way is a dependency that a later value import follows. Each phase reruns the script and replaces this page’s tables, so the numbers shrink in the history rather than in anyone’s memory.

Since the baseline

• The pure core is domain/. The parser, the query language, the index state, the task rules, and the ranking, graph, facet, and mention engines live in src/domain, which imports nothing outside itself and src/shared. What stays in src/core is the services that do I/O: the index and its watcher, the scanner, storage, and the MCP protocol.
• Commands are adapters over src/services, each of which decides one feature and returns a result the command words: tags, parking, rollover, review, templates, tasks, Move to, the agenda, links, capture, pins, and export.
• Phase 5 made extension.ts a 35-line composition root. src/composition/services.ts builds every service once, and each of the nineteen features in src/ui/commands/<feature>/register.ts registers its commands against them. The features import the Services type from the composition module, which imports the classes it builds from ui/commands: a pair of folders, type-only in that direction, and the shape the plan’s register(context, services) implies.
• Phase 6 moved every page into src/webview/<page>/, bundles on a shared Preact core in src/webview/shared/. Its 90 modules reach no vscode: they import ui/protocol (the typed messages and snapshots), four pure domain folders (domain/markdown, domain/dashboard, domain/graph, domain/tasks), and each other. Since Phase 7 the script groups them by folder (src/webview/<page> and src/webview/shared), and every one of those rows reads 0 and 0 in the first table.
• ui/state and ui/webview no longer import each other, and the two known violations left with them. The state builders sent HTML they rendered with ui/webview/rendering.ts; they now send the token tree of domain/markdown/inline.ts and blockExcerpt.ts (decision 0015), the pages draw it, and rendering.ts and sanitize-html are gone. The host side of the pages is src/ui/webview/host/ (WebviewHost, the shell, the narrowing helpers, the shared handlers) and a controller and narrowing table per page in src/ui/webview/pages/<page>/; messages.ts is gone.
• The 25 new test:unit suites are the per-page narrowing tables (*-messages), the domain modules the pages share with the host (markdown-inline, markdown-block-excerpt, notes-graph-communities, notes-graph-simulation, widget-catalog, task-columns, calendar-day-panel), navigation-service, page-narrowing, help-manifest, guide-links, icons, and spacing-scale, and three of the template-parity suites (webview-shared, webview-tasks, webview-query-editor), which compare against recordings of the deleted templates since step 7.
• What got worse in Phase 6. The suites that reach vscode only through what they test went from 24 to 35, and the suites that import it themselves from 70 to 72. Ten reach it through src/test/pages.ts, which renders each page’s shell against a stand-in webview and imports vscode for that webview’s type. A page’s host and controller are vscode adapters by design, so a suite of a page’s host reaches it either way. ui/webview’s imports of ui/commands grew from 48 to 56 (still 24 modules), and ui/commands and ui/webview still import each other, through chooseTheme.ts, the one known violation left in ui/. src/ui/webview grew from 35 files to 65, 47 of which reach vscode.
• Phase 7 deleted the re-export shims. src/core/types.ts, src/ui/protocol/index.ts, src/domain/markdown/taskMetadata.ts, src/ui/webview/panelPriority.ts, and the ui/state modules that only passed on what had moved to domain/ are gone, and no other module passes on a name that moved: each importer names the module that declares what it imports. With core/types.ts went the core-not-to-ui violation. src/domain/model/index.ts stays, as the model’s one entry point, and the protocol re-exports the few model types the pages name, since a page may import only the protocol.
• The page suites no longer reach vscode. A page’s shell is given its theme and zen mode by its host (readPageChrome in src/ui/webview/host/pageChrome.ts) rather than reading the settings, host/pageShell.ts and components.ts name no vscode type, and src/test/pageWebview.ts hands out a stand-in URI, so src/test/pages.ts renders every page without the extension host. The ten suites that reached vscode only through it, and calendar and components-primitives, which reached it through the calendar’s shell, run under test:unit: 126 of 221, and the suites that reach vscode only through what they test went from 35 to 23.
• The two known violations are one file. ui/commands/chooseTheme.ts imports getDeckardTheme from ui/webview/themes.ts and the theme names from ui/webview/themeNames.ts, which it took through themes.ts until the shims went.

Folders and vscode

Imports between folders

Folders that import each other:

• src/composition/services.ts and src/ui/commands import each other.
• src/domain/index and src/domain/query import each other.
• src/domain/query and src/domain/tasks import each other.
• src/ui/commands and src/ui/views import each other.
• src/domain/markdown and src/domain/tasks import each other.
• src/ui/commands and src/ui/webview import each other.

Module cycles

None.

The search-store worker

src/core/storage/searchStoreWorker.ts is its own esbuild entry. Its closure within src:

• src/core/storage/parsedFileCodec.ts
• src/core/storage/searchDatabase.ts
• src/core/storage/searchStoreWorker.ts
• src/domain/model/blocks.ts
• src/domain/model/graph.ts
• src/domain/model/index.ts
• src/domain/model/inline.ts
• src/domain/model/notes.ts
• src/domain/model/preferences.ts
• src/domain/model/query.ts
• src/domain/model/relatedNotes.ts
• src/domain/model/tags.ts
• src/domain/model/tasks.ts
• src/domain/model/workspaceIndex.ts

What it imports from outside src: fs, node:sqlite, path, worker_threads.

Which suites need the extension host

The suites under test:unit: agenda-service, assignee, assistant-tool-table, assistant-tools, calendar-day-panel, calendar-math, calendar-messages, calendar, calendarPage-messages, capture-box, capture-lines, capture-service, capture-words, change-reactions, change-watcher, changelog, completion-context, components-primitives, dashboard-messages, dashboard-widgets, debounce, due-date-wording, emitter, export-results, export-service, frontmatter-tags, frontmatter, guards, guide-links, help-manifest, help-messages, icons, index-publishing, line-shapes, link-rewrites, link-service, markdown-block-excerpt, markdown-inline, markdown-parser, mcp-protocol, move-service, naming, navigation-service, note-boundaries, note-embeds, note-links, notes-graph-behavior, notes-graph-communities, notes-graph-messages, notes-graph-simulation, notes-graph-state, outline-tree, page-loader, page-narrowing, page-sheets, parked-commands, parked, parking-service, paths, people-recency, pin-service, pinned-notes, preference-snapshots, preferences-invariants, preferences-maintenance, preferences-prune, preferences-roundtrip, preferences-schema, preferences, prose-excerpt, query-block, query-builder-webview, query-language, query-links, query-values, quick-find-actions, related-notes-behavior, related-notes-evaluation, repeat-rule-problems, result-table, review-service, rollover-service, search-history, search-page-messages, search-store, setting-toggles, shared-html, sidebarNotes-messages, spacing-scale, stats-messages, tag-board, tag-hygiene, tag-navigation, tag-service, tag-target, tagged-entries, task-board-messages, task-board-page, task-columns, task-draft, task-metadata, task-policy, task-query, task-rules, task-service, task-steps, task-title-parity, template-service, templates, text, theme-preview, timing, try-next, view-publisher, view-state, warm-start, webview-page, webview-query-editor, webview-saved-state, webview-shared, webview-tasks, widget-catalog, wiki-link-targets, word-similarity, workspace, write-history.

For the suites that reach vscode only through what they test, the module on the shortest path that imports vscode itself:

Module-level state

Whether each piece of hidden state is still declared at module level, and, while it is, how many other files use a function that reads or writes it:

Known violations

How to regenerate

node scripts/import-graph-report.js                          # every table above
npx depcruise src --config .dependency-cruiser.cjs --no-ignore-known --output-type err
                                                              # every violation, known ones included
npx depcruise src --config .dependency-cruiser.cjs --output-type archi | dot -T svg > layers.svg
                                                              # the folder-level picture, with Graphviz installed

When a phase removes known violations, npm run lint:deps:baseline rewrites .dependency-cruiser-known-violations.json, and the diff of that file is the record of what the phase fixed.